[
https://issues.apache.org/jira/browse/GEODE-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677058#comment-16677058
]
ASF subversion and git services commented on GEODE-5984:
--------------------------------------------------------
Commit a3b648613536d55376c5bc87509f0efc4f9f8f02 in geode's branch
refs/heads/feature/GEODE-5986 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a3b6486 ]
GEODE-5984 Address LGTM recommendations
Addressing minor issues in javadocs and code reported by LooksGoodToMe.
One change that I made wasn't reported by that tool: I removed
two static variables from AcceptorImpl that duplicated variables in
Handshake.
This closes #2780
> Address LGTM recommendations
> ----------------------------
>
> Key: GEODE-5984
> URL: https://issues.apache.org/jira/browse/GEODE-5984
> Project: Geode
> Issue Type: Bug
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There is a list of 87 minor "recommendations" from the LooksGoodToMe CI
> integration report for 2b4313a:
> Implicit conversion from Array to String.
> Avoid automated semicolon insertion (97% of all statements in the enclosing
> function have an explicit semicolon).
> @param for phantom parameters
> Missing spaces in concatenated string literals
> Others are in javascript files used by geode-book and Pulse.
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=list&severity=recommendation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
