[
https://issues.apache.org/jira/browse/GEODE-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681695#comment-16681695
]
Bruce Schuchardt commented on GEODE-6023:
-----------------------------------------
This synchronization was added in this commit, which should probably be
scrutinized for other synchronization issues:
{noformat}
commit be4551191a17b9f50169f375798785ab5373e975
Author: Udo Kohlmeyer <ukohlme...@pivotal.io>
Date: Tue Aug 22 09:45:05 2017 -0700
GEODE-3416: Reduce synchronization blockages in SocketCloser. This now
closes #702
Remove synchronization blocks around HashMap. Replace that implementation
with simpler ThreadPool that is not unbounded and does not grow as the
number of remoteAddress (clients/peers) are added
{noformat}
> synchronization on non-final variable
> -------------------------------------
>
> Key: GEODE-6023
> URL: https://issues.apache.org/jira/browse/GEODE-6023
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
> Priority: Major
>
> The class SocketCloser synchronizes on a non-final boxed instance variable,
> "closed".
> {code}
> synchronized (closed) {
> if (!this.closed) {
> this.closed = true;
> } else {
> return;
> }
> }
> {code}
> This is probably okay but it's flagged as an ERROR by LGTM scans and we
> shouldn't be using auto-boxed variables in non-test code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
