[
https://issues.apache.org/jira/browse/GEODE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717613#comment-16717613
]
ASF GitHub Bot commented on GEODE-6172:
---------------------------------------
nabarunnag commented on a change in pull request #21: GEODE-6172: Configure
geode properties for benchmarks
URL: https://github.com/apache/geode-benchmarks/pull/21#discussion_r240712578
##########
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartLocator.java
##########
@@ -38,13 +39,10 @@ public StartLocator(int locatorPort) {
@Override
public void run(TestContext context) throws Exception {
- Properties properties = new Properties();
+ Properties properties = GeodeProperties.serverProperties();
Review comment:
Locator taking serverProperties seems a bit out of place. Possible refactor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Configure Geode properties for all benchmarks
> ---------------------------------------------
>
> Key: GEODE-6172
> URL: https://issues.apache.org/jira/browse/GEODE-6172
> Project: Geode
> Issue Type: Improvement
> Components: benchmarks
> Reporter: Dan Smith
> Assignee: Helena Bales
> Priority: Major
> Labels: pull-request-available
>
> The geode benchmarks should run with gemfire properties that are tuned for
> performance. We should configure all benchmarks to run with these properties
> set:
> {noformat}
> eviction-heap-percentage=65
> critical-heap-percentage=90
> archive-disk-space-limit=150
> archive-file-size-limit=10
> conserve-sockets=false
> enable-time-statistics=true
> jmx-manager=true
> jmx-manager-port=1099
> jmx-manager-start=true
> jmx-manager-update-rate=2000
> locator-wait-time=120
> log-disk-space-limit=100
> log-file-size-limit=10
> log-level=config
> remove-unresponsive-client=true
> statistic-archive-file=XXXX
> statistic-sample-rate=1000
> statistic-sampling-enabled=true
> log-file=XXXX
> distributed-system-id=0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
