[
https://issues.apache.org/jira/browse/GEODE-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717715#comment-16717715
]
ASF GitHub Bot commented on GEODE-6131:
---------------------------------------
nabarunnag closed pull request #24: GEODE-6131: Pass geode version as a
parameter.
URL: https://github.com/apache/geode-benchmarks/pull/24
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/geode-benchmarks/build.gradle b/geode-benchmarks/build.gradle
index a804675..ee0fa09 100644
--- a/geode-benchmarks/build.gradle
+++ b/geode-benchmarks/build.gradle
@@ -25,6 +25,7 @@ version '1.0-SNAPSHOT'
sourceCompatibility = 1.8
def outputDir = project.hasProperty('outputDir') ?
project.findProperty('outputDir') : new File(project.buildDir,
"benchmarks").getAbsolutePath()
+def geodeVersion = project.hasProperty('geodeVersion') ?
project.findProperty('geodeVersion') : '1.+'
repositories {
mavenCentral()
@@ -32,7 +33,7 @@ repositories {
dependencies {
compile(group: 'junit', name: 'junit', version: '4.12')
- compile(group: 'org.apache.geode', name: 'geode-core', version: '1.7.0')
+ compile(group: 'org.apache.geode', name: 'geode-core', version:
geodeVersion)
compile(group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.25')
compile(project(':harness'))
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Extract versions from build.grade into gradle.properties for benchmarks
> -----------------------------------------------------------------------
>
> Key: GEODE-6131
> URL: https://issues.apache.org/jira/browse/GEODE-6131
> Project: Geode
> Issue Type: Task
> Components: benchmarks
> Reporter: Dan Smith
> Assignee: nabarun
> Priority: Major
> Labels: pull-request-available
>
> Extract the version numbers out of the build.gradle file and into
> gradle.properties for the geode-benchmarks repo, like we have done with
> geode-examples.
> This will have the side benefit that we will then be able to run the
> benchmarks against an old geode release by passing a command line parameter,
> eg.
> {noformat}
> ./gradlew benchmark -Pgeode.version=1.6.0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
