[
https://issues.apache.org/jira/browse/GEODE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720987#comment-16720987
]
ASF subversion and git services commented on GEODE-6146:
--------------------------------------------------------
Commit 54863e38edb44e78edf71cf8b95585b1319c9ae6 in geode-benchmarks's branch
refs/heads/develop from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=54863e3 ]
GEODE-6146: Cleaned Portfolio benchmark object. (#26)
* Using automatic reflection based pdx serialization
* Cleaned up the statics in the constructors
* Generics are used.
* Removed unused member variable.
> Cleanup PortfolioPdx object in benchmarks
> -----------------------------------------
>
> Key: GEODE-6146
> URL: https://issues.apache.org/jira/browse/GEODE-6146
> Project: Geode
> Issue Type: Task
> Components: benchmarks
> Reporter: Dan Smith
> Assignee: nabarun
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The PortfolioPdx object has a number of issues that need cleaning up. We
> should aim for this to be a good example of what a domain object would look
> like it a real deployment. Here are some of the things that need fixing:
> * The object extends PdxSerializable and contains other objects that are
> DataSerializable and Serializable. We should just be using auto serialization
> * Missing generics
> * Separate out generation logic from the constructors and don't rely on a
> bunch of static fields. Perhaps a separate PortfolioPdx supplier class?
> * Make the object used in the benchmarks configurable. PutTask currently
> hardcodes Portfolio PDX. Perhaps it should take a function that returns an
> object, so we can create benchmarks with different data types using the same
> task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
