[
https://issues.apache.org/jira/browse/GEODE-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726279#comment-16726279
]
ASF subversion and git services commented on GEODE-6176:
--------------------------------------------------------
Commit afd082c67895abf6e9467cc4fbf1bf7cc0c28995 in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=afd082c ]
GEODE-6176: Make FunctionService testable with internal delegates
Introduce new internal FunctionExecutionService API interfaces:
* FunctionExecutionService
* InternalFunctionExecutionService
Implement interfaces with:
* InternalFunctionExecutionServiceImpl
Collapse FunctionServiceManager into InternalFunctionExecutionServiceImpl
Change the two static API classes to delegate to an instance of
InternalFunctionExecutionServiceImpl:
* FunctionService (User API) -- only has private internal changes
* InternalFunctionService -- now extends FunctionService
Geode classes that use the static API classes directly can now be
changed to depend on one of the two interfaces using constructor
injection to facilitate unit testing without PowerMock.
> Refactor FunctionService internals to permit unit testing without PowerMock
> ---------------------------------------------------------------------------
>
> Key: GEODE-6176
> URL: https://issues.apache.org/jira/browse/GEODE-6176
> Project: Geode
> Issue Type: Improvement
> Components: functions
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> FunctionService is a fully static User API. Any code that depends on
> FunctionService must use PowerMock in order to be unit tested. Refactor
> FunctionService internals to permit unit testing without PowerMock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
