[ 
https://issues.apache.org/jira/browse/GEODE-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736396#comment-16736396
 ] 

ASF subversion and git services commented on GEODE-6237:
--------------------------------------------------------

Commit 961c75f56681a66a3056f0d51556803bf7d6ca00 in geode's branch 
refs/heads/feature/GEODE-5787-dunit-internal from Patrick Rhomberg
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=961c75f ]

 GEODE-6237: Opt into publication rather than opting out. (#3038)

* Remove 'disableMavenPublishing' declaration and use.
* Remove unused publication block that was otherwise disabled in 
:extensions:geode-modules-assembly.
* Flatten if/else:'if/else:"if/else:"' logic in publish.gradle
* Move askpass block to rootProject build.gradle
* Use relative pathing rather than ${rootDir} in Gradle apply from statements

Co-authored-by: Robert Houghton <[email protected]>
Co-authored-by: Patrick Rhomberg <[email protected]>


> Publication should be "opt-in" rather than injected into all subprojects
> ------------------------------------------------------------------------
>
>                 Key: GEODE-6237
>                 URL: https://issues.apache.org/jira/browse/GEODE-6237
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently, we inject publication logic into all subprojects in our 
> {{publish.gradle}}.  Then, many subprojects "opt-out" of this via our custom 
> {{disableMavenPublishing}} global method.
> Rather than activating publication for all modules, then disabling it for 
> some select internal modules, it would be better for those modules we intend 
> to publish to "opt-in" to publication and apply the plugin specifically to 
> those modules.  Moreover, this iterates us towards modularity within each 
> subproject module, rather than the injection and tight-coupling that the 
> {{subprojects}} and {{allprojects}} configurations represent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to