[ 
https://issues.apache.org/jira/browse/GEODE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743380#comment-16743380
 ] 

Barry Oglesby commented on GEODE-6267:
--------------------------------------

After adding code to logout the Subjects in ClientUserAuths and 
CacheClientProxy:
{noformat}
 num #instances #bytes class name
----------------------------------------------
 1: 79717 7093992 [C
 2: 79610 1910640 java.lang.String
 3: 11596 1599472 [B
 4: 31794 1017408 java.util.concurrent.ConcurrentHashMap$Node
 5: 7477 841096 java.lang.Class
 6: 9998 719856 org.apache.geode.distributed.internal.membership.gms.GMSMember
 7: 9998 479904 
org.apache.geode.distributed.internal.membership.InternalDistributedMember
 8: 5956 445384 [Ljava.lang.Object;
 9: 753 408176 [J
 10: 20810 332960 java.lang.Object
 11: 10022 320704 java.net.InetAddress$InetAddressHolder
 12: 9989 319648 org.apache.geode.distributed.DurableClientAttributes
 13: 9988 319616 
org.apache.geode.internal.cache.tier.sockets.ClientProxyMembershipID
 14: 2980 262240 java.lang.reflect.Method
 15: 7956 254592 java.util.HashMap$Node
 16: 10221 245304 java.lang.Long
 17: 10017 240408 java.net.Inet4Address
 18: 122 223824 [Ljava.util.concurrent.ConcurrentHashMap$Node;
 19: 4881 208488 [I
 20: 11264 202016 [Ljava.lang.String;
 21: 2139 198488 [Ljava.util.HashMap$Node;
 22: 2119 169520 java.lang.reflect.Constructor
 23: 4120 164800 java.util.LinkedHashMap$Entry
 24: 1726 96656 java.util.LinkedHashMap
 25: 1760 84480 java.util.HashMap
Total 391292 19641912
{noformat}
There is still a leak here in I think ClientProxyMembershipIDs. I'll take a 
look at that.

> Subjects are not logged out when a client departs causing a memory leak
> -----------------------------------------------------------------------
>
>                 Key: GEODE-6267
>                 URL: https://issues.apache.org/jira/browse/GEODE-6267
>             Project: Geode
>          Issue Type: Bug
>          Components: security
>            Reporter: Barry Oglesby
>            Assignee: Barry Oglesby
>            Priority: Major
>
> When a client with security enabled connects to a server, the 
> IntegratedSecurityService logs in a Subject. This causes a SimpleSession to 
> be created.
> The Subject is stored in ClientUserAuths.uniqueIdVsSubject.
> Here is a stack showing the SimpleSession creation:
> {noformat}
> [warning 2019/01/08 18:02:42.993 PST server1 <ServerConnection on port 40401 
> Thread 0> tid=0x4e] SimpleSession.<init> invoked:
> java.lang.Exception
>  at org.apache.shiro.session.mgt.SimpleSession.<init>(SimpleSession.java:99)
>  at 
> org.apache.shiro.session.mgt.SimpleSessionFactory.createSession(SimpleSessionFactory.java:44)
>  at 
> org.apache.shiro.session.mgt.DefaultSessionManager.newSessionInstance(DefaultSessionManager.java:163)
>  at 
> org.apache.shiro.session.mgt.DefaultSessionManager.doCreateSession(DefaultSessionManager.java:154)
>  at 
> org.apache.shiro.session.mgt.AbstractValidatingSessionManager.createSession(AbstractValidatingSessionManager.java:136)
>  at 
> org.apache.shiro.session.mgt.AbstractNativeSessionManager.start(AbstractNativeSessionManager.java:99)
>  at 
> org.apache.shiro.mgt.SessionsSecurityManager.start(SessionsSecurityManager.java:152)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.getSession(DelegatingSubject.java:336)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.getSession(DelegatingSubject.java:312)
>  at 
> org.apache.shiro.mgt.DefaultSubjectDAO.mergePrincipals(DefaultSubjectDAO.java:204)
>  at 
> org.apache.shiro.mgt.DefaultSubjectDAO.saveToSession(DefaultSubjectDAO.java:166)
>  at org.apache.shiro.mgt.DefaultSubjectDAO.save(DefaultSubjectDAO.java:147)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.save(DefaultSecurityManager.java:383)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.createSubject(DefaultSecurityManager.java:350)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.createSubject(DefaultSecurityManager.java:183)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:283)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
>  at 
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:139)
>  at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.verifyCredentials(HandShake.java:1688)
>  at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.setCredentials(ServerConnection.java:1044)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.PutUserCredentials.cmdExecute(PutUserCredentials.java:52)
>  at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:163)
>  at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:797)
>  at 
> org.apache.geode.internal.cache.tier.sockets.LegacyServerConnection.doOneMessage(LegacyServerConnection.java:85)
>  at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1179)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$4$1.run(AcceptorImpl.java:641)
>  at java.lang.Thread.run(Thread.java:745)
> {noformat}
> When the client disconnects, the ClientUserAuths is cleaned up (in cleanup), 
> but the Subjects are not logged out.
> With subscription-enabled=true, an additional Subject is created and stored 
> in the CacheClientProxy subject. This Subject is not logged out either.
> Here is a stack showing the SimpleSession creation:
> {noformat}
> [warning 2019/01/08 18:02:43.023 PST server1 <Client Queue Initialization 
> Thread 0> tid=0x52] SimpleSession.<init> invoked:
> java.lang.Exception
>  at org.apache.shiro.session.mgt.SimpleSession.<init>(SimpleSession.java:99)
>  at 
> org.apache.shiro.session.mgt.SimpleSessionFactory.createSession(SimpleSessionFactory.java:44)
>  at 
> org.apache.shiro.session.mgt.DefaultSessionManager.newSessionInstance(DefaultSessionManager.java:163)
>  at 
> org.apache.shiro.session.mgt.DefaultSessionManager.doCreateSession(DefaultSessionManager.java:154)
>  at 
> org.apache.shiro.session.mgt.AbstractValidatingSessionManager.createSession(AbstractValidatingSessionManager.java:136)
>  at 
> org.apache.shiro.session.mgt.AbstractNativeSessionManager.start(AbstractNativeSessionManager.java:99)
>  at 
> org.apache.shiro.mgt.SessionsSecurityManager.start(SessionsSecurityManager.java:152)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.getSession(DelegatingSubject.java:336)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.getSession(DelegatingSubject.java:312)
>  at 
> org.apache.shiro.mgt.DefaultSubjectDAO.mergePrincipals(DefaultSubjectDAO.java:204)
>  at 
> org.apache.shiro.mgt.DefaultSubjectDAO.saveToSession(DefaultSubjectDAO.java:166)
>  at org.apache.shiro.mgt.DefaultSubjectDAO.save(DefaultSubjectDAO.java:147)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.save(DefaultSecurityManager.java:383)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.createSubject(DefaultSecurityManager.java:350)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.createSubject(DefaultSecurityManager.java:183)
>  at 
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:283)
>  at 
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
>  at 
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:139)
>  at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.verifyCredentials(HandShake.java:1688)
>  at 
> org.apache.geode.internal.cache.tier.sockets.CacheClientNotifier.registerGFEClient(CacheClientNotifier.java:343)
>  at 
> org.apache.geode.internal.cache.tier.sockets.CacheClientNotifier.registerClient(CacheClientNotifier.java:279)
>  at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$ClientQueueInitializerTask.run(AcceptorImpl.java:1844)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$3$1.run(AcceptorImpl.java:611)
>  at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Both of these cause a memory leak of SimpleSessions.
> In my simple test where a client with subscription-enabled=true connects and 
> disconnects, 3 SimpleSessions are created. Each additional client 
> connect/disconnect causes 3 more SimpleSessions to be created.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to