[
https://issues.apache.org/jira/browse/GEODE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767417#comment-16767417
]
ASF subversion and git services commented on GEODE-6395:
--------------------------------------------------------
Commit 6bec09fcdc08502ef82b122560bbc1b833fb21b1 in geode's branch
refs/heads/develop from Patrick Rhomberg
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6bec09f ]
GEODE-6395: Use md5 as Spotless cache value. (#3186)
* This acts as a safeguard against developers forgetting to bump the input to
'bumpThisNumberIfACustomStepChanges'
> Safeguard spotless custom rule bump
> -----------------------------------
>
> Key: GEODE-6395
> URL: https://issues.apache.org/jira/browse/GEODE-6395
> Project: Geode
> Issue Type: Improvement
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Spotless method {{bumpThisNumberIfACustomStepChanges}} should have its
> input changed whenever a custom rule is changed or added. Failure to do so
> can cause spotless to not execute, or to throw an NPE in rare instances.
> Developers can easily overlook this however. As an alternative, we could
> pass the sha of the spotless file itself to this method, ensuring that any
> change to spotless will cause the spotless cache to invalidate itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
