[ 
https://issues.apache.org/jira/browse/GEODE-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812780#comment-16812780
 ] 

ASF subversion and git services commented on GEODE-6584:
--------------------------------------------------------

Commit 6eb32e22dbeefd63a8ea0ceb11101b9e6378ef83 in geode's branch 
refs/heads/develop from Helena Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6eb32e2 ]

GEODE-6584: remove unecessary synchronization (#3387)

Remove synchronization around changing values that could be volatile and
that are atomic. Results in a performance gain.

* make processMessages in ServerConnection private and add getter and
setter
* refactor check for if the system is shutting down and stopping
processing of messages in ServerConnection


> Performance Improvement: Do not synchronize on volatile variables
> -----------------------------------------------------------------
>
>                 Key: GEODE-6584
>                 URL: https://issues.apache.org/jira/browse/GEODE-6584
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Helena Bales
>            Assignee: Helena Bales
>            Priority: Major
>              Labels: performance-benchmark
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In ServerConnection, do not synchronize on volatile boolean processMessage. 
> It is not necessary and will have a negative performance impact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to