[
https://issues.apache.org/jira/browse/GEODE-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833959#comment-16833959
]
ASF subversion and git services commented on GEODE-6670:
--------------------------------------------------------
Commit 0e342fd3515e92a99c44bd05c661624d180045dd in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0e342fd ]
GEODE-6670: remove getCacheServers allocation
getCacheServers now returns a canonical instance instead of creating a new
instance for each call.
> GemFireCacheImpl.getCacheServers should not allocate a new ArrayList
> everytime it is called
> -------------------------------------------------------------------------------------------
>
> Key: GEODE-6670
> URL: https://issues.apache.org/jira/browse/GEODE-6670
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: performance
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The current implementation of GemFireCacheImpl.getCacheServers allocates a
> new ArrayList each time it is called if the cache has any cache servers that
> are not gateway receivers.
> We should instead maintain a list of all the non-gateway cache servers (like
> we currently do with the "allCacheServers" list).
> I saw the method called multiple times per pr put on a cache server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)