[ 
https://issues.apache.org/jira/browse/GEODE-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834019#comment-16834019
 ] 

ASF subversion and git services commented on GEODE-6719:
--------------------------------------------------------

Commit 117a27d2c6ff134c3ca0a8c18d0e1312e810a44f in geode's branch 
refs/heads/develop from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=117a27d ]

GEODE-6719 : Handling default disktore request from AppServers (#3516)

* If the existing region was using the DEFAULT diskstore but it was not 
explicitly linked to the
   * region using setDiskStore or disk-store-name tags. diskStoreName is set as 
null. This is
   * interpreted by Geode as use the DEFAULT diskstore.
   * This link between the existing region and a diskstore may happen because 
the diskstore is
   * named as DEFAULT.
   * The user may change the default location of the DEFAULT diskstore but the 
AppServer always
   * requests it be at the default location.
   * This comparison with always used to fail and the AppServer could not start 
up.
   * The goal of this method is that if both existing region and requested 
region are using the
   * DEFAULT diskstore, the existing regions take precedence and the requested 
ones are ignored.
   * This is current behavior which can be seen in
   * {@link RegionAttributesCreation#sameAs(RegionAttributes)}
   * The logic is to intercept the configurations for the regions and only if 
the both the regions
   * have diskStoreName set to null, meaning both should use the DEFAULT 
diskstore, the diskstore
   * names are sent as DEFAULT in the configuration and send to geode-core for 
comparison for rest
   * of the region attributes.

> App servers using custom DEFAULT diskstores should be able to restart
> ---------------------------------------------------------------------
>
>                 Key: GEODE-6719
>                 URL: https://issues.apache.org/jira/browse/GEODE-6719
>             Project: Geode
>          Issue Type: Bug
>          Components: http session
>            Reporter: nabarun
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Issue:
>  # Start servers with DEFAULT diskstores with custom directory location other 
> than '.' and do not set the diskstore in the region attributes tag in the 
> cache xml. Since it is named DEFAULT, it should automatically link itself to 
> the region.
>  # Start the app serverĀ 
>  # Stop the app server
>  # Start the app server.
>  # This causes a failure as app server requests it create the default 
> diskstore at . but the default diskstore was already created at the custom 
> location.
> Solution:
>  * If the existing region and the requested region both use the default disk 
> store then the existing diskstore properties with take precedence over the 
> requested ones.
>  * The requested disktore properties will be ignored if there is a default 
> diskstore already present.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to