[
https://issues.apache.org/jira/browse/GEODE-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857021#comment-16857021
]
ASF subversion and git services commented on GEODE-6321:
--------------------------------------------------------
Commit 5678143786e89ce41df9acefae4a4bdf25f16519 in geode's branch
refs/heads/feature/GEODE-6321 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5678143 ]
GEODE-6321: This is race caused by not enough SLOP time (it could use up to
300ms). The next test testShutdown2 used 3 seconds sleep,
but verify at least run for 2 seconds. Apply the same design to resolve the
race.
The logic is already verified in assertTrue(ex.awaitTermination())
> ScheduledThreadPoolExecutorWithKeepAliveJUnitTest's testShutdown() has
> invalid expectation
> -------------------------------------------------------------------------------------------
>
> Key: GEODE-6321
> URL: https://issues.apache.org/jira/browse/GEODE-6321
> Project: Geode
> Issue Type: Bug
> Reporter: xiaojian zhou
> Assignee: xiaojian zhou
> Priority: Major
> Labels: test
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {noformat}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/325
> reproduced following failure:
> org.apache.geode.internal.ScheduledThreadPoolExecutorWithKeepAliveJUnitTest >
> testShutdown FAILED
> java.lang.AssertionError: Shutdown did not wait to task to complete. Only
> waited 3850
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.geode.internal.ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.testShutdown(ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java:226)
> {noformat}
> The root cause is:
> The test detected the shutdown finished within 10 seconds as expected. But it
> also expected it to finish longer than 4 seconds. This is an invalid
> expectation. Usually it did finish after 4 seconds, but on some running VMs,
> it finished earlier (such as 3850 ms this time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
