[ 
https://issues.apache.org/jira/browse/GEODE-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888254#comment-16888254
 ] 

ASF subversion and git services commented on GEODE-6979:
--------------------------------------------------------

Commit 1d3ae3c46c097948c7e04a1f93793d54e351a376 in geode's branch 
refs/heads/develop from Alberto Bustamante Reyes
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d3ae3c ]

GEODE-6979: Clean files in ExportLogsStatsDistributedTestBase (#3812)

- Use SerializableTemporaryFolder to clean generated files after tests.

> ExportLogsStatsDistributedTestBase not removing generated files
> ---------------------------------------------------------------
>
>                 Key: GEODE-6979
>                 URL: https://issues.apache.org/jira/browse/GEODE-6979
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Alberto Bustamante Reyes
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> When running distributed tests of geode-web I found out that 
> ExportLogsOverHttpDistributedTest is failing due to unexpected zip files 
> found.
> The test works fine when run alone (`./gradlew geode-web:distributedTest 
> --tests=ExportLogsOverHttpDistributedTest`) but
> it fails when it runs with the rest of distributed tests.
> {noformat}
> > Task :geode-web:distributedTest
> org.apache.geode.management.internal.cli.commands.ExportLogsOverHttpDistributedTest
>  > withFiles_savedToLocatorSpecifiedRelativeDir FAILED
>     java.lang.AssertionError: 
>     Expecting empty but 
> was:<[/home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029358.zip,
>         
> /home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029320.zip,
>         
> /home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029410.zip]>
> 136 tests completed, 1 failed
> {noformat}
> I found out that ExportLogsStatsOverHttpDistributedTest is creating these 
> three zip files which are not deleted.
> This is a fragment of the standard output of 
> ExportLogsStatsOverHttpDistributedTest:
> {noformat}
> Command result for <export logs>: 
> Logs exported to: 
> /home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029320.zip
> Command result for <export logs --stats-only>: 
> Logs exported to: 
> /home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029358.zip
> Command result for <export logs --logs-only>: 
> Logs exported to: 
> /home/alb3rtobr/git/geode/geode-web/build/distributedTest/exportedLogs_1563455029410.zip
> {noformat}
> ExportLogsStatsOverHttpDistributedTest should delete these files.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to