[ 
https://issues.apache.org/jira/browse/GEODE-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890300#comment-16890300
 ] 

ASF subversion and git services commented on GEODE-6798:
--------------------------------------------------------

Commit b42c8d3f3e06f64a49728e04787f1856d76b8082 in geode's branch 
refs/heads/develop from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b42c8d3 ]

GEODE-6798 Refactor client function execution logic (#3822)

* Changes to create instance using suppliers, as and when needed.
This is to fix performance degradation seen with grabage collection.

* Replace set instance with empty collection
Refactor to removed unused arguments from method


> Refactoring client function execution logic
> -------------------------------------------
>
>                 Key: GEODE-6798
>                 URL: https://issues.apache.org/jira/browse/GEODE-6798
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server, functions
>            Reporter: Anilkumar Gingade
>            Assignee: Anilkumar Gingade
>            Priority: Major
>              Labels: GeodeCommons
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> While working on GEODE-6677; issue with client function retry semantic, we 
> came across duplicating the fix on many places; as the function execution is 
> supported in many ways:
> onServer(pool)
> onServers(pool)
> onRegion()
> onRegions()
> onServer(regionService)
> onServers(regionService)
> Additional methods when data affinity is provided.
> In all of these cases, the execution is done by having execute() and 
> reExecute(); and copies of it to support, execution using function object and 
> function id, repeating the same logic.
> The code can be refactored to remove the duplicating logic and make it easier 
> to add any changes/fixes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to