[
https://issues.apache.org/jira/browse/GEODE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902408#comment-16902408
]
ASF subversion and git services commented on GEODE-7042:
--------------------------------------------------------
Commit ab5c2df147e18a3f9750f8be9d40c368b5e9d920 in geode's branch
refs/heads/develop from Aaron Lindsey
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab5c2df ]
GEODE-7042: Set server status to "online" after all startup tasks complete
(#3878)
ServerLauncher start will now wait until all asynchronous startup tasks
complete to update server status as "online".
Previously, the server status was set to "online" before all of the
startup tasks had completed. This provided users with incorrect facts
about the system and its availability. This commit changes the behavior
of ServerLauncher.start() so that it waits for all of the asynchronous
startup tasks to complete before returning the "online" status. The GFSH
"start server" command relies on this status, so this also has the
effect of making the command wait for all startup tasks to complete
before returning.
* ServerLauncher.start() waits for startup tasks to complete
* Improve testability of ServerLauncher
* Extract ControllableProcess interface
* Change InternalResourceManager support for asynchronous startup tasks
* Move the responsibility for chaining the completion and exception
actions of startup tasks to ServerLauncher
Co-authored-by: Aaron Lindsey <[email protected]>
Co-authored-by: Kirk Lund <[email protected]>
Co-authored-by: Dale Emery <[email protected]>
> Wait until all startup tasks complete to update server status as "online"
> -------------------------------------------------------------------------
>
> Key: GEODE-7042
> URL: https://issues.apache.org/jira/browse/GEODE-7042
> Project: Geode
> Issue Type: Improvement
> Reporter: Aaron Lindsey
> Assignee: Aaron Lindsey
> Priority: Major
> Labels: observability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently, the server status is set to "online" before all of the startup
> tasks have completed. This tells users incorrect facts about the system and
> its availability.
> *Scenario:*
> Given a server has just been started
> When the following threads have completed:
> [Async] [Optional] Begin redundancy recovery
> [Async] [Optional] Begin recovery of values from disk
> And when the synchronous thread of .start() for the ServerLauncher that
> started the server completes without exception
> Then the 'status' bit of the ServerLauncher should be set to 'online'
> (currently this is set to online regardless of Async processes)
> *Notes:*
> GFSH utilizes this 'online' status to return from the 'start server' command.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)