[ 
https://issues.apache.org/jira/browse/GEODE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906500#comment-16906500
 ] 

ASF subversion and git services commented on GEODE-6959:
--------------------------------------------------------

Commit bb509b0e283917e94a4f6046791e59516f1320a4 in geode's branch 
refs/heads/release/1.10.0 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bb509b0 ]

GEODE-6959: Prevent NPE in GMSMembershipManager for null AlertAppender (#3899)

If a custom log4j2.xml is used without specifying the Geode AlertAppender,
GMSMembershipManager may throw a NullPointerException when invoking
AlertAppender.getInstance().stopSession() during a forceDisconnect. This
change prevents the NullPointerException allowing forceDisconnect to finish.

Users using Spring Boot with Logback are more likely to hit this bug.

Co-authored-by: Mark Hanson mhan...@pivotal.io

(cherry picked from commit dd15fec1f2ecbc3bc0cdfc42072252c379e0bb89)


> NPE if AlertAppender is not defined
> -----------------------------------
>
>                 Key: GEODE-6959
>                 URL: https://issues.apache.org/jira/browse/GEODE-6959
>             Project: Geode
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Vadim Lotarev
>            Assignee: Kirk Lund
>            Priority: Major
>             Fix For: 1.10.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> NullPointer exception is produced if custom Log4j2.xml is used and 
> AlertAppender is not defined.
>  
> {code:java}
> 01:43:12.760 WARN  [] JGRP000039: 192.168.100.109<v3>:10100: failed to 
> deliver OOB message [dst: 192.168.100.109<v3>:10100, src: 
> 192.168.100.109<v0>:41000 (2 headers), size=208 bytes, 
> flags=OOB|DONT_BUNDLE|NO_FC|SKIP_BARRIER]: java.lang.NullPointerException 
> java.lang.NullPointerException
>       at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2558)
>  ~[geode-core-1.9.0.jar:?]
>       at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:1093)
>  ~[geode-core-1.9.0.jar:?]
>       at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:674)
>  ~[geode-core-1.9.0.jar:?]
>       at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1897)
>  ~[geode-core-1.9.0.jar:?]
>       at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1328)
>  ~[geode-core-1.9.0.jar:?]
>       at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1266)
>  ~[geode-core-1.9.0.jar:?]
>       at org.jgroups.JChannel.invokeCallback(JChannel.java:816) 
> ~[jgroups-3.6.14.Final.jar:3.6.14.Final]
>       at org.jgroups.JChannel.up(JChannel.java:741) 
> ~[jgroups-3.6.14.Final.jar:3.6.14.Final]
>       at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030) 
> ~[jgroups-3.6.14.Final.jar:3.6.14.Final]
> {code}
>  I would propose to make AlertAppender optional.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to