[
https://issues.apache.org/jira/browse/GEODE-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918987#comment-16918987
]
ASF subversion and git services commented on GEODE-7119:
--------------------------------------------------------
Commit 50df321b5520fcdf211f8a9f0e2136aef18b86eb in geode's branch
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=50df321 ]
GEODE-7119 Version ordinal constants are byte but should be short (#3988)
Changed all Version ordinal declarations to be of type 'short' instead of
type 'byte'. Changed the constructor to take a 'short' instead of a
'byte'.
While we could change Version to use ints instead of shorts I don't see
a compelling reason to do that at this time.
> Version ordinal constants are byte but should be short
> ------------------------------------------------------
>
> Key: GEODE-7119
> URL: https://issues.apache.org/jira/browse/GEODE-7119
> Project: Geode
> Issue Type: Bug
> Components: membership, serialization
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The ordinal constants in Version.java are all of type "byte" but the
> "ordinal" instance variable is a "short". The constructor for Version takes
> a "byte" but it should take a "short".
> Version.GEODE_1_11_0_ORDINAL is currently set at 107 but it should be
> increased to 110 to give us some spare ordinals in case we need to create a
> patch release of 1.11 that has on-wire changes.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
