[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938032#comment-16938032
]
ASF subversion and git services commented on GEODE-7237:
--------------------------------------------------------
Commit 3efb71d8a5eedb0c70d9fbe7d77b2872b1dce5cb in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3efb71d ]
GEODE-7237: Remove log4j-core manipulation from GfshRule (#4089)
Creation of geode-log4j widened a race condition in GfshRule in which
the process being forked would start printing output before the
ProcessLogger had been created and started in order to intercept that
output.
The widening of that race condition resulted in CI failures of
ConnectCommandAcceptanceTest.
ProcessLogger does not appear to have any real need for manipulating
log4j-core which is what widens the race condition far enough to fail
in CI.
Removing the manipulation of log4j-core from ProcessLogger reduces
the race condition for consistent passing. The window itself is still
there but without resorting to something like MainLauncher [1], there's
no way to completely close the window.
[1] geode-junit: org.apache.geode.test.process.MainLauncher
If ConnectCommandAcceptanceTest or other tests using GfshRule fail
after this commit, then we'll need to use something like MainLauncher.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
> --------------------------------------------------------
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
> Reporter: Aaron Lindsey
> Assignee: Kirk Lund
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
