[ 
https://issues.apache.org/jira/browse/GEODE-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dick Cavender closed GEODE-6573.
--------------------------------

> ConnectionManager has some methods on it that should be on Connection instead
> -----------------------------------------------------------------------------
>
>                 Key: GEODE-6573
>                 URL: https://issues.apache.org/jira/browse/GEODE-6573
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> org.apache.geode.cache.client.internal.pooling.ConnectionManager has three 
> methods on it that do not belong: getConnection(Connection), 
> activate(Connection), passivate(Connection, boolean).
> All three of these methods should instead be on the Connection interface. 
> None of them have anything to do with the manager.
> getConnection(Connection) is requesting the wrapped connection from a 
> connection. So a better name for it would be getWrappedConnection.
> Not all implementations of the Connection interface need to support wrapping 
> or activation but those implementations can just implement these operations 
> as a noop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to