[
https://issues.apache.org/jira/browse/GEODE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-7291:
-----------------------------
Description:
Creating tags without values is something that Micrometer recommends against
doing. With our common tags we need to consider the implications of adding them
outside of a server/locator member of a cluster.
{code}
Given I create a cache without a member name
When I add a meterregistry to that cache
Then I should not see the member common tag:
- member
And I should see the following common tags:
- cluster
- host
- member_type
{code}
{code}
Given I create a clientcache through Java
When I add a meterregistry to that cache
Then I should not see the following common tags:
- cluster
And I should see the following common tags:
- host
- member
- member_type
{code}
was:
Creating tags without values is something that Micrometer recommends against
doing. With our common tags we need to consider the implications of adding them
outside of a server/locator member of a cluster.
{code}
Given I create a cache or clientcache through Java
When I add a meterregistry to that cache
Then I should not see the following common tags:
- cluster (value is gemfire.distributed-system-id)
- member (value is gemfire.name)
And I should see the following common tags:
- host (value is host name)
- member_type (value is member_type value)
{code}
{code}
Given I create a cache or clientcache through Java
When I add a meterregistry to that cache
Then I should not see the following common tags:
- cluster (value is gemfire.distributed-system-id)
- member (value is gemfire.name)
And I should see the following common tags:
- host (value is host name)
- member_type (value is member_type value)
{code}
> Cluster and Member micrometer common tags should not be used with empty values
> ------------------------------------------------------------------------------
>
> Key: GEODE-7291
> URL: https://issues.apache.org/jira/browse/GEODE-7291
> Project: Geode
> Issue Type: Improvement
> Components: statistics
> Affects Versions: 1.11.0
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Creating tags without values is something that Micrometer recommends against
> doing. With our common tags we need to consider the implications of adding
> them outside of a server/locator member of a cluster.
> {code}
> Given I create a cache without a member name
> When I add a meterregistry to that cache
> Then I should not see the member common tag:
> - member
> And I should see the following common tags:
> - cluster
> - host
> - member_type
> {code}
> {code}
> Given I create a clientcache through Java
> When I add a meterregistry to that cache
> Then I should not see the following common tags:
> - cluster
> And I should see the following common tags:
> - host
> - member
> - member_type
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
