[
https://issues.apache.org/jira/browse/GEODE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953981#comment-16953981
]
ASF subversion and git services commented on GEODE-7291:
--------------------------------------------------------
Commit e2adc0dc5f861dbc47457524ca9b6246d3737c74 in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e2adc0d ]
GEODE-7291: Prevent empty micrometer tags
* Do not include member meter tag if member name is missing
* Do not include cluster meter tags in a client
Co-authored-by: Aaron Lindsey <alind...@pivotal.io>
> Cluster and Member micrometer common tags should not be used with empty values
> ------------------------------------------------------------------------------
>
> Key: GEODE-7291
> URL: https://issues.apache.org/jira/browse/GEODE-7291
> Project: Geode
> Issue Type: Improvement
> Components: statistics
> Affects Versions: 1.11.0
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Creating tags without values is something that Micrometer recommends against
> doing. With our common tags we need to consider the implications of adding
> them outside of a server/locator member of a cluster.
> {code}
> Given I create a cache without a member name
> When I add a meterregistry to that cache
> Then I should not see the member common tag:
> - member
> And I should see the following common tags:
> - cluster
> - host
> - member_type
> {code}
> {code}
> Given I create a clientcache through Java
> When I add a meterregistry to that cache
> Then I should not see the following common tags:
> - cluster
> And I should see the following common tags:
> - host
> - member
> - member_type
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
