[
https://issues.apache.org/jira/browse/GEODE-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975280#comment-16975280
]
ASF subversion and git services commented on GEODE-7445:
--------------------------------------------------------
Commit 4a92c8e4fd071e540843411a8ea0baf94fd9a1fe in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4a92c8e ]
GEODE-7445: do not use internal class (#4331)
> A public interface method should not return an instance of an "internal" class
> ------------------------------------------------------------------------------
>
> Key: GEODE-7445
> URL: https://issues.apache.org/jira/browse/GEODE-7445
> Project: Geode
> Issue Type: Bug
> Reporter: John Blum
> Assignee: Darrel Schneider
> Priority: Minor
>
> The {{org.apache.geode.cache.TransactionId}} class's {{getMemberId()}} method
> returns an instance of
> {{org.apache.geode.distriburted.internal.InternalDistributedMember}}.
> See here:
> https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/TransactionId.html#getMemberId--
> If anything, the getMemberId methods should return and "ID" and not (even) a
> {{DistributedMember}}, but, if it must, then it should adhere to the "public"
> API by return an instance of
> [{{org.apache.geode.distributed.DistributedMember}}|https://geode.apache.org/releases/latest/javadoc/org/apache/geode/distributed/DistributedMember.html]!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
