[ 
https://issues.apache.org/jira/browse/GEODE-7301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977632#comment-16977632
 ] 

Bruce J Schuchardt commented on GEODE-7301:
-------------------------------------------

Here's an idea: we could keep (and deprecate) SocketCreator.resolve_dns and 
avoid overwriting the hostName in 
InternalDistributedMember.fromDataPre_GFE_9_0_0_0 for "loner" identifiers.  A 
"loner" is either a client or it's a server that isn't part of a cluster.  To 
avoid overwriting we could move
{code:java}
this.hostName = SocketCreator.resolve_dns
    ? SocketCreator.getCanonicalHostName(inetAddr, hostName) : 
inetAddr.getHostAddress(); {code}
into the "else" clause of
{code:java}
if (vmKind == ClusterDistributionManager.LONER_DM_TYPE) {
  this.uniqueTag = DataSerializer.readString(in);
} else { {code}
I think this is the only thing that depends on the toString representation of a 
membership identifier.  If there are other failures they ought to be discussed 
but they're probably problems with tests.

When we have a major (not backward compatible) release we can completely remove 
SocketCreator.resolve_dns and always use hostnames.

 

 

 

 

> Remove code that disables the use of hostnames in membership identifiers
> ------------------------------------------------------------------------
>
>                 Key: GEODE-7301
>                 URL: https://issues.apache.org/jira/browse/GEODE-7301
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Mario Kevo
>            Priority: Minor
>              Labels: low-hanging-fruit, newbie
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When network-partition-detection is enabled membership identifiers use 
> numeric host IP addresses instead of host names.  This should be changed to 
> always use host names - much of the rest of Geode uses hostnames regardless 
> of how this setting is configured, so we're dependent on the computer's host 
> name resolution service anyway.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to