[
https://issues.apache.org/jira/browse/GEODE-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983944#comment-16983944
]
ASF subversion and git services commented on GEODE-4187:
--------------------------------------------------------
Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]
GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest
Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
hang
Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently
Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest
Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService
Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances
Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender
> PersistentColocatedPartitionedRegionDUnitTest.testRebalanceDuringRecovery
> hangs
> -------------------------------------------------------------------------------
>
> Key: GEODE-4187
> URL: https://issues.apache.org/jira/browse/GEODE-4187
> Project: Geode
> Issue Type: Bug
> Components: regions
> Reporter: Lynn Gallinat
> Assignee: Kirk Lund
> Priority: Major
> Labels: flaky
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Analysis from Dan Smith:
> The hang in distributedTests was in
> PersistentColocatedPartitionedRegionDUnitTest testRebalanceDuringRecovery. I
> don’t know if there is any more info we have other than that this test hung,
> but it was stuck for at least an hour and a half before concourse killed the
> job:
> ~/Downloads/progress.darwin hang distributedTest-progress.txt
> Started @ 2017-12-28 18:30:31.703 +0000
> 2017-12-28 19:14:15.760 +0000
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
> testRebalanceDuringRecovery
> Ended @ 2017-12-28 20:50:53.673 +0000
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/51
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
