[ 
https://issues.apache.org/jira/browse/GEODE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984009#comment-16984009
 ] 

ASF subversion and git services commented on GEODE-6499:
--------------------------------------------------------

Commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d in geode's branch 
refs/heads/feature/GEODE-7507 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fc20f2f ]

GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest

Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
  hang

Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently

Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest

Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService

Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances

Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender


> PersistentColocatedPartitionedRegionDUnitTest: Timed out waiting 60000 
> milliseconds for AsyncInvocation to complete.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-6499
>                 URL: https://issues.apache.org/jira/browse/GEODE-6499
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mark Hanson
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: flaky
>         Attachments: PersistentColocatedPartitionedRegionDUnitTest.tgz
>
>
> {noformat}
>  
> Task :geode-core:distributedTest
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testHierarchyOfColocatedChildPRsMissingGrandchild FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 60000 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testHierarchyOfColocatedChildPRsMissingGrandchild(PersistentColocatedPartitionedRegionDUnitTest.java:979)
>  
>  
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testMultipleColocatedChildPRsMissingWithSequencedStart FAILED
>  java.util.concurrent.TimeoutException: Timed out waiting 60000 milliseconds 
> for AsyncInvocation to complete.
>  at 
> org.apache.geode.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:462)
>  at org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:412)
>  at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testMultipleColocatedChildPRsMissingWithSequencedStart(PersistentColocatedPartitionedRegionDUnitTest.java:865)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to