Blake Bender created GEODE-7520:
-----------------------------------
Summary: Don't run clang-format in regular build steps
Key: GEODE-7520
URL: https://issues.apache.org/jira/browse/GEODE-7520
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
*We should* stop running clang-format as part of the "build" step in all CI
build pipelines
*Because* Visual Studio ships with _broken_ versions of clang-format from time
to time that crash while formatting our code, and this kills the Windows build
job.
We already have an agreed-upon version of clang-format, it's already running on
Travis CI for pull requests _and_ in private CI pipelines, we do _not_ need it
to be run for all flavors on all platforms every time we push to a branch with
a private pipeline or to a release branch or to develop. To fix this properly,
once and for all, we should:
i. disable clang-format in the build step for all flavors of all pipelines
ii. Create a separate clang-format job in all pipelines for _one_ flavor, e.g.
Ubuntu Debug
iii. Create an (optional) git commit hook for developers to use that will _not
allow you to push_ with outstanding formatting changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
