[ 
https://issues.apache.org/jira/browse/GEODE-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Smith updated GEODE-7533:
---------------------------------
    Description: 
I noticed when using the HTTP Session Management Module for AppServers that my 
tomcat environment would act oddly when my webapp was reloaded. I tracked this 
down to the fact that catalina.home and catalina.base system properties were 
missing when the webapp reloaded.

 

A quick search of the Geode code base found a couple of unexplainable lines in:

{{geode-http-service/src/main/java/org/apache/geode/internal/cache/InternalHttpService.java}}

in the close() method there are 2 calls to System.clearProperty() which 
essentially clear catalina.home and catalina.base.

 

I am guessing that these lines exist from a previous state of this 
InternalHttpService when it was perhaps using an embedded Tomcat instance. Now 
the class appears to be implemented using Jetty and there are no other 
references to the catalina properties than the lines that clear them.

 

This is likely also causing issues with the HTTP Session Management Module for 
Tomcat. I was a least able to workaround this issue by disabling the embedded 
HTTP server in the filter properties that configured the HTTP Session 
Management Module.

 

Probably these 2 lines should just be removed from the InternalHttpService 
class...

  was:
I noticed when using the HTTP Session Management Module for AppServers that my 
tomcat environment would act oddly when my webapp was reloaded. I tracked this 
down to catalina.home and catalina.base system properties being missing when 
the webapp reloaded.

 

A quick search of the Geode code base found a couple of unexplainable lines in:

{{geode-http-service/src/main/java/org/apache/geode/internal/cache/InternalHttpService.java}}

in the close method there are 2 calls to System.clearProperty() which 
essentially clear catalina.home and catalina.base.

 

I am guess that these lines are exist from a previous state of this 
InternalHttpService when it was perhaps using an embedded Tomcat instance. Now 
the class appears to be implemented using Jetty and there are no other 
references to the catalina properties than the lines that clear them.

 

This is likely also causing issues with the HTTP Session Management Module for 
Tomcat. I was a least able to workaround this issue by disabling the embedded 
HTTP server in the filter properties that configured the HTTP Session 
Management Module.

 

Probably these 2 lines should just be removed from the InternalHttpService 
class...


> System Properties catalina.home and catalina.base are cleared during webapp 
> reloads when using HTTP Session Management Module
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-7533
>                 URL: https://issues.apache.org/jira/browse/GEODE-7533
>             Project: Geode
>          Issue Type: Bug
>          Components: http session
>            Reporter: Charles Smith
>            Priority: Major
>
> I noticed when using the HTTP Session Management Module for AppServers that 
> my tomcat environment would act oddly when my webapp was reloaded. I tracked 
> this down to the fact that catalina.home and catalina.base system properties 
> were missing when the webapp reloaded.
>  
> A quick search of the Geode code base found a couple of unexplainable lines 
> in:
> {{geode-http-service/src/main/java/org/apache/geode/internal/cache/InternalHttpService.java}}
> in the close() method there are 2 calls to System.clearProperty() which 
> essentially clear catalina.home and catalina.base.
>  
> I am guessing that these lines exist from a previous state of this 
> InternalHttpService when it was perhaps using an embedded Tomcat instance. 
> Now the class appears to be implemented using Jetty and there are no other 
> references to the catalina properties than the lines that clear them.
>  
> This is likely also causing issues with the HTTP Session Management Module 
> for Tomcat. I was a least able to workaround this issue by disabling the 
> embedded HTTP server in the filter properties that configured the HTTP 
> Session Management Module.
>  
> Probably these 2 lines should just be removed from the InternalHttpService 
> class...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to