[ 
https://issues.apache.org/jira/browse/GEODE-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Blum updated GEODE-7531:
-----------------------------
    Description: 
A recent 
[change|https://github.com/apache/geode/blob/rel/v1.10.0/geode-core/src/main/java/org/apache/geode/internal/cache/PoolManagerImpl.java#L169-L174]
 to the {{o.a.g.internal.cache.PoolManagerImpl}} class expects all 
{{o.a.g.cache.client.Pools}} registered with the 
{{o.a.g.cache.client.PoolManager}} to be 
{{o.a.g.cache.client.internal.PoolImp}} objects.

This is certainly not going to be the case for Unit Tests that properly "mock" 
1 or more {{Pool}} instances and additionally need to register the {{Pool}} 
with the {{PoolManager}}.  While the later may not be as common for application 
code, it is more certainly common and in some cases, necessary for framework 
code.

  was:
A recent 
[change|https://github.com/apache/geode/blob/rel/v1.10.0/geode-core/src/main/java/org/apache/geode/internal/cache/PoolManagerImpl.java#L169-L174]
 to the {{o.a.g.internal.cache.PoolManagerImpl}} class expects all 
{{o.a.g.cache.client.Pools}} registered with the 
{{o.a.g.cache.client.PoolManager}} to be 
{{o.a.g.cache.client.internal.PoolImp}} object.

This is certainly not going to be the case for Unit Tests that properly "mock" 
1 or more {{Pool}} instances and additionally need to register the {{Pool}} 
with the {{PoolManager}}.  While the later may not be as common for application 
code, it is more certainly common and in some cases, necessary for framework 
code.


> PoolManagerImpl.unregister(:Pool) naively assumes all Pool object instances 
> are PoolImpls
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-7531
>                 URL: https://issues.apache.org/jira/browse/GEODE-7531
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>    Affects Versions: 1.10.0
>         Environment: Apache Geode based applications on the JVM.
>            Reporter: John Blum
>            Priority: Blocker
>
> A recent 
> [change|https://github.com/apache/geode/blob/rel/v1.10.0/geode-core/src/main/java/org/apache/geode/internal/cache/PoolManagerImpl.java#L169-L174]
>  to the {{o.a.g.internal.cache.PoolManagerImpl}} class expects all 
> {{o.a.g.cache.client.Pools}} registered with the 
> {{o.a.g.cache.client.PoolManager}} to be 
> {{o.a.g.cache.client.internal.PoolImp}} objects.
> This is certainly not going to be the case for Unit Tests that properly 
> "mock" 1 or more {{Pool}} instances and additionally need to register the 
> {{Pool}} with the {{PoolManager}}.  While the later may not be as common for 
> application code, it is more certainly common and in some cases, necessary 
> for framework code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to