[
https://issues.apache.org/jira/browse/GEODE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993788#comment-16993788
]
ASF subversion and git services commented on GEODE-6807:
--------------------------------------------------------
Commit bde1f71211d022c25a930057f02010d4a2967a79 in geode's branch
refs/heads/develop from Jason Huynh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bde1f71 ]
Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and
adviseAllEventsOrCached" (#4189)" (#4212)" (#4442)
This reverts commit 80efe5cae9848f4fab45bb5c199c1e1f1fdf0eae.
> changing advisors to cache advice can improve performance
> ---------------------------------------------------------
>
> Key: GEODE-6807
> URL: https://issues.apache.org/jira/browse/GEODE-6807
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Darrel Schneider
> Assignee: Mario Ivanac
> Priority: Major
> Labels: performance
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Cluster messaging uses advisors to know what member of the cluster should be
> sent a message.
> Currently, every time and advisor is asked for advice to iterates over its
> profiles building up the advice in a HashSet that is returned.
> I found on a partitioned region client/server put benchmark (32 client
> threads, 2 servers with redundancy 1) that if I changed the method
> adviseAllEventsOrCached to remember what it computed, that it caused the put
> throughput to increase by 8%. [Update I reran and did not see an improvement
> so the original 8% difference may have been caused by something else].
> Advisors know when a profile is added, removed, or modified. When that
> happens any advice it has cached can be dropped. Also, the requestors of
> advice need to expect the Set they get back to be unmodifiable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
