[
https://issues.apache.org/jira/browse/GEODE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993798#comment-16993798
]
ASF subversion and git services commented on GEODE-7503:
--------------------------------------------------------
Commit 0345938538b34fc1e8948c7e9a57755bdd8b16ee in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0345938 ]
GEODE-7503: Cleanup GemFireCacheImpl (#4436)
* Move inner-classes to bottom of outer class
* Move fields to top of class
* More fields
* Fixup
* Fix IJ inspection warnings
* Remove bug system ticket numbers
* Cleanup javadocs, toString, and comments
* Use @VisibleForTesting annotation
* Move toString method and backupFiles field
* Pull javadocs up to interfaces.
Define VisibleForTesting methods in InternalCacheForTesting.
Identify more methods as VisibleForTesting.
* Fixup javadocs and minor warnings in Cache interfaces.
* Move unchecked util methods to UncheckedUtils inner class
* Move static constants and fields to top of class.
Rename FIVE_HOURS to FIVE_HOURS_MILLIS.
Review older TODOs.
* Move volatile fields above non-final fields
* Move non-final fields below volatile and final fields
* Move final fields above volatile fields
* wip
* Adjust whitespace and line feeds.
Remove more TODOs and comments.
Fix spelling typo.
* Import various static methods and constants
Adjust more line feeds
Adjust more white space
* Weaken declared types where it makes sense
Add more static imports
* Remove unnecessary uses of final on local vars
* Remove uncessary uses of final on local vars
* Fixup unchecked types
Restore return types to match the interfaces
* Minor cleanup
* Change Consumer<Void> to Runnable (duh)
* Adjust line feeds of large if-statement
* Remove SuppressWarnings
* Fix AssemblyContentsIntegrationTest
* Fixup GemFireCacheImpl
> Creating cache after closing cache may throw
> DistributedSystemDisconnectedException
> -----------------------------------------------------------------------------------
>
> Key: GEODE-7503
> URL: https://issues.apache.org/jira/browse/GEODE-7503
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> This problem reproduces if you attempt to create a Cache using the
> CacheFactory immediately after closing a Cache.
> {noformat}
> org.apache.geode.distributed.DistributedSystemDisconnectedException: This
> connection to a distributed system has been disconnected.
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.checkConnected(InternalDistributedSystem.java:945)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.getDistributionManager(InternalDistributedSystem.java:1665)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.<init>(GemFireCacheImpl.java:791)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:187)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)