[
https://issues.apache.org/jira/browse/GEODE-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018704#comment-17018704
]
Dave Barnes edited comment on GEODE-7714 at 1/20/20 6:32 PM:
-------------------------------------------------------------
I think it's confusing to allow the option with an equals sign but no following
string (\{{--statistic-archive-file=}}). Is that allowed in any other gfsh
option? I think if the equals sign is given, a following string should be
required.
Note that there are several cases in which a gfsh option that takes a value can
be specified without the value, but this is also done without the equals sign.
And I think those cases are always with arguments of type Boolean. When
specified in this fashion, they default to 'true', the opposite of the meaning
of your proposed implementation.
I would like to hear some opinions from Geode developers, as I'm not intimately
familiar with the code itself, just the docs.
was (Author: dbarnes97):
I think it's confusing to allow the option with an equals sign but no following
string (`--statistic-archive-file=`). Is that allowed in any other gfsh option?
I think if the equals sign is given, a following string should be required.
Note that there are several cases in which a gfsh option that takes a value can
be specified without the value, but this is also done without the equals sign.
And I think those cases are always with arguments of type Boolean. When
specified in this fashion, they default to 'true', the opposite of the meaning
of your proposed implementation.
I would like to hear some opinions from Geode developers, as I'm not intimately
familiar with the code itself, just the docs.
> Disable statistic-archive-file not working
> -------------------------------------------
>
> Key: GEODE-7714
> URL: https://issues.apache.org/jira/browse/GEODE-7714
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {color:#172b4d}Once the statistic writing to file is configured, it can't be
> turned off. It should be possible to disable it by setting the
> statistic-archive-file parameter to an empty string, but it fails:{color}
> {color:#172b4d} {color}
> {color:#172b4d}Cluster-1 gfsh>alter runtime --statistic-archive-file={color}
> {color:#172b4d}Please provide a relevant parameter(s){color}
> {color:#172b4d} {color}
> {color:#172b4d} {color}
> {color:#172b4d}This parameter is ignored if it is set with another
> configuration parameter:{color}
> {color:#172b4d} {color}
> {color:#172b4d}GemFire properties defined at the runtime{color}
> {color:#172b4d}statistic-archive-file :
> /opt/dbservice/data/a.txt{color}
> {color:#172b4d}statistic-sampling-enabled :
> {color}{color:#910091}true{color}
> {color:#172b4d} {color}
> {color:#172b4d} {color}
> {color:#172b4d}Cluster-1 gfsh>alter runtime --statistic-archive-file=
> --enable-statistics={color}{color:#910091}true{color}
> {color:#000091}Runtime{color}{color:#172b4d} configuration altered
> successfully {color}{color:#910091}for{color}{color:#172b4d} the following
> member(s){color}
> {color:#172b4d}192.168.110.65(eric-data-kvdb-ag-server-1:1)<v1>:41000{color}
> {color:#172b4d}192.168.120.20(eric-data-kvdb-ag-server-0:1)<v2>:41000{color}
> {color:#172b4d} {color}
> {color:#172b4d}GemFire properties defined at the runtime{color}
> {color:#172b4d}statistic-archive-file :
> /opt/dbservice/data/a.txt{color}
> {color:#172b4d}statistic-sampling-enabled :
> {color}{color:#910091}true{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
