[
https://issues.apache.org/jira/browse/GEODE-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026322#comment-17026322
]
ASF subversion and git services commented on GEODE-7597:
--------------------------------------------------------
Commit 434b5b0923a54d5042acd074863d3254358f2617 in geode's branch
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=434b5b0 ]
GEODE-7597: Factor out code needed in Membership from SocketCreator (#4637)
* GEODE-7597: Factor out code needed in Membership from SocketCreator
Implemented a new TcpSocketCreatorImpl. Due to GeodeHttpClientRule
dependencies this and associated interfaces are in geode-common. I'd
rather have them in geode-tcp-server.
SocketCreator now subclasses TcpSocketCreatorImpl and I've removed the
adapter class, which is no longer needed.
* added missing files
* fixing dunit failure and moving TcpSocketCreator back to the tcp-server
project
* fixing bind address and inheritance problems in socket creators
* fixes for unit test failures
* spotless
* relax assertion in test that fails stress-testing
> Factor out code needed in Membership from SocketCreator
> -------------------------------------------------------
>
> Key: GEODE-7597
> URL: https://issues.apache.org/jira/browse/GEODE-7597
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bill Burcham
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{SocketCreator}} is part of {{geode-core}}. But we need a
> {{TcpSocketCreator}} to test membership. Rather than creating a new
> implementation of {{TcpSocketCreator}} used only in tests, we'll factor out
> the code from {{SocketCreator}} into TBD class/TBD module for use by both
> {{SocketCreator}} and membership tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
