upthewaterspout commented on issue #4963: URL: https://github.com/apache/geode/pull/4963#issuecomment-618527691
> … so far, I’m not convinced that it’s safe to remove the 1st early out. Are you sure it’s safe to invoke these calls more than once? The current behavior never invokes them more than once. It looks like it might be ok to have a second thread go in there? If DistributedSystem.disconnect() is safe to call twice, it should be ok. It looks like that method also synchronizes on GemFireCacheImpl and also has some interesting wait logic to wait until other threads have finished disconnecting. Hmm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
