[
https://issues.apache.org/jira/browse/GEODE-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094649#comment-17094649
]
ASF GitHub Bot commented on GEODE-8032:
---------------------------------------
kirklund commented on pull request #5011:
URL: https://github.com/apache/geode/pull/5011#issuecomment-620702140
Tomcat session tests failed in UpgradeTestOpen. Unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unit tests should not pollute the environment
> ---------------------------------------------
>
> Key: GEODE-8032
> URL: https://issues.apache.org/jira/browse/GEODE-8032
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
>
> Unit tests should not pollute the environment.
> From https://www.artima.com/weblogs/viewpost.jsp?thread=126923:
> A test is not a unit test if:
> * It talks to the database
> * It communicates across the network
> * It touches the file system
> * It can't run at the same time as any of your other unit tests
> * You have to do special things to your environment (such as editing config
> files) to run it.
> Tests that do these things are good but they should be an integration or
> system test instead of a unit test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
