[
https://issues.apache.org/jira/browse/GEODE-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095673#comment-17095673
]
ASF subversion and git services commented on GEODE-8028:
--------------------------------------------------------
Commit aa330f317f7ed8e7676d282424626fcdb3412c0e in geode's branch
refs/heads/mass-test-run from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=aa330f3 ]
GEODE-8028: refactor RedisCommandType (#4998)
* Instead of each enum reimplementing getExecutor and getDataType
now those fields are final and initialized with a private constructor.
The executor will now be initialized when this class is loaded instead
of waiting until the first call of getExecutor.
Comments on each enum were also removed since the correspondence to
a REDIS command is obvious and this is an internal API.
* removed unused getDataType
> refactor RedisCommandType
> -------------------------
>
> Key: GEODE-8028
> URL: https://issues.apache.org/jira/browse/GEODE-8028
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Priority: Major
> Fix For: 1.13.0
>
>
> The RedisCommandType enum is more complicated than it needs to be.
> It has a getDataType method that is never used.
> It lazily initializes the executor which means each enum instance needs its
> own subclass.
> The enum code itself is very verbose.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
