[
https://issues.apache.org/jira/browse/GEODE-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097070#comment-17097070
]
ASF GitHub Bot commented on GEODE-8059:
---------------------------------------
dschneider-pivotal opened a new pull request #5035:
URL: https://github.com/apache/geode/pull/5035
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use a single function to route redis commands to primary
> --------------------------------------------------------
>
> Key: GEODE-8059
> URL: https://issues.apache.org/jira/browse/GEODE-8059
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> The redis implementation now uses a function to route the execution of a
> redis command to the server that has the primary for a particular key.
> Currently a function exists for each command (sadd, srem, smembers, del).
> Each time we want to do this for another redis command it is a bunch of work
> if we add another function.
> Instead we could have a single function that takes an enum describing what
> command it is being asked to execute.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
