[
https://issues.apache.org/jira/browse/GEODE-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101281#comment-17101281
]
ASF GitHub Bot commented on GEODE-8083:
---------------------------------------
onichols-pivotal commented on a change in pull request #5066:
URL: https://github.com/apache/geode/pull/5066#discussion_r421165685
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -202,3 +202,15 @@ tests:
PLATFORM: windows
RAM: '64'
name: WindowsUnit
+- ARTIFACT_SLUG: apicheck
+ CALL_STACK_TIMEOUT: '20700'
Review comment:
maybe not applicable to this job? But in general CALL_STACK_TIMEOUT
should be 10-15 minutes less than EXECUTE_TEST_TIMEOUT, which you've set to 1h.
So `2700` might be a better choice.
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -202,3 +202,15 @@ tests:
PLATFORM: windows
RAM: '64'
name: WindowsUnit
+- ARTIFACT_SLUG: apicheck
+ CALL_STACK_TIMEOUT: '20700'
+ CPUS: '4'
+ DUNIT_PARALLEL_FORKS: '0'
+ EXECUTE_TEST_TIMEOUT: 1h
+ GRADLE_TASK: geode-assembly:japicmp
+ MAX_IN_FLIGHT: 1
+ PARALLEL_DUNIT: 'false'
+ PARALLEL_GRADLE: 'false'
+ PLATFORM: linux
+ RAM: '16'
+ name: ApiCheck
Review comment:
will this result in both ApiCheckOpenJdk8 and ApiCheckOpenJdk11 jobs?
Is there any value to having both? Ideally we would add a new flag in
jinja.variables to allow each job to specify JDK version(s) desired per job.
But that can be a future enhancement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add API check job to CI
> -----------------------
>
> Key: GEODE-8083
> URL: https://issues.apache.org/jira/browse/GEODE-8083
> Project: Geode
> Issue Type: Improvement
> Components: ci
> Reporter: Sean Goller
> Priority: Major
>
> In order to combat API breaking changes, we need a CI job that compares the
> current API against the last release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
