[
https://issues.apache.org/jira/browse/GEODE-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101962#comment-17101962
]
ASF GitHub Bot commented on GEODE-8076:
---------------------------------------
prettyClouds commented on a change in pull request #5019:
URL: https://github.com/apache/geode/pull/5019#discussion_r420437859
##########
File path:
geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/rest/internal/web/controllers/GetAllEntries.java
##########
@@ -29,6 +29,7 @@
public class GetAllEntries implements Function {
+ @SuppressWarnings("unchecked")
Review comment:
why are we changing stuff in rest.internal.web.controllers?
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/RedisSetCommands.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.set;
+
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.geode.redis.internal.ByteArrayWrapper;
+
+public interface RedisSetCommands {
Review comment:
What was the underlying reason behind changing this interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> simplify redis concurrency code
> -------------------------------
>
> Key: GEODE-8076
> URL: https://issues.apache.org/jira/browse/GEODE-8076
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> Currently when doing a redis set operation, for example sadd, the code has to
> be careful to deal with other threads concurrently changing the same set.
> It does this in a number of ways but this could be simplified by having a
> higher level layer of the code ensure that for a given redis "key" operations
> will done in sequential order.
> This can be done safely in a distributed cluster because we now route all
> operations for a given key to the server that is storing the primary copy of
> data for that key.
> I spike was done and we found that this form of locking did not hurt
> performance. Since it allows simpler code that is less likely to have subtle
> concurrency issues we plan on merging the work done in the spike into the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
