[
https://issues.apache.org/jira/browse/GEODE-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102102#comment-17102102
]
ASF GitHub Bot commented on GEODE-7998:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5042:
URL: https://github.com/apache/geode/pull/5042#discussion_r421851477
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/PubSubImpl.java
##########
@@ -91,6 +100,11 @@ public void execute(FunctionContext<Object[]> context) {
publishMessageToSubscribers((String) publishMessage[0], (byte[])
publishMessage[1]);
context.getResultSender().lastResult(subscriberCount);
}
+
+ @Override
Review comment:
Consider adding a comment as to why you don't want this function to be HA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Geode-Redis: Add test cases for pub-sub for server shutdown scenarios
> ---------------------------------------------------------------------
>
> Key: GEODE-7998
> URL: https://issues.apache.org/jira/browse/GEODE-7998
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Venkateswara Prasath Durairaj
> Priority: Major
>
> Dunit tests to start multiple servers and test the following:
> * 2 clients subscribed to a channel on separate servers
> * 1 client publishing
> * 1 server gracefully shut down
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
