[
https://issues.apache.org/jira/browse/GEODE-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102250#comment-17102250
]
ASF GitHub Bot commented on GEODE-8089:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5058:
URL: https://github.com/apache/geode/pull/5058#discussion_r421935431
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/SScanExecutor.java
##########
@@ -108,53 +99,17 @@ public void executeCommand(Command command,
ExecutionHandlerContext context) {
return;
}
- @SuppressWarnings("unchecked")
- List<ByteArrayWrapper> returnList =
- (List<ByteArrayWrapper>) getIteration(new ArrayList<>(set),
matchPattern,
- count, cursor);
-
+ RedisSetCommands redisSetCommands =
+ new
RedisSetCommandsFunctionExecutor(context.getRegionProvider().getSetRegion());
+ List<Object> returnList = redisSetCommands.sscan(key, matchPattern, count,
cursor);
+ if (returnList == null) {
+ returnList = Collections.emptyList();
+ }
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> change more redis set commands to use function and deltas
> ---------------------------------------------------------
>
> Key: GEODE-8089
> URL: https://issues.apache.org/jira/browse/GEODE-8089
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Priority: Major
>
> GEODE-8048 was a good start of a new implementation of redis sets but it only
> did 4 of the set commands.
> All the redis set commands should use functions and deltas in their
> implementation.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
