[ 
https://issues.apache.org/jira/browse/GEODE-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102706#comment-17102706
 ] 

ASF GitHub Bot commented on GEODE-7707:
---------------------------------------

moleske commented on a change in pull request #5061:
URL: https://github.com/apache/geode/pull/5061#discussion_r422235205



##########
File path: geode-docs/tools_modules/gfsh/command-pages/connect.html.md.erb
##########
@@ -185,7 +182,7 @@ Successfully connected to: [host=GemFireStymon, port=1099]
 **Example of connecting to a remote locator over HTTP:**
 
 ``` pre
-gfsh>connect --use-http=true 
--url="http://myLocatorHost.example.com:8080/gemfire/v1";
+gfsh>connect --url="http://myLocatorHost.example.com:8080/gemfire/v1";

Review comment:
       This might be more of a @davebarnes97 question, but since 
`http://<host>:<port>/geode-mgmt/v1` is used as the example in gfsh, should 
docs use something more similar to 
`http://myLocatorHost.example.com:8080/geode-mgmt/v1` (remove the `gemfire` 
part)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Tab completing `--url` on `connect` gives two default values 
> -------------------------------------------------------------
>
>                 Key: GEODE-7707
>                 URL: https://issues.apache.org/jira/browse/GEODE-7707
>             Project: Geode
>          Issue Type: Bug
>          Components: management
>            Reporter: Michael Oleske
>            Assignee: Alberto Bustamante Reyes
>            Priority: Major
>              Labels: pull-request-available
>
> Expected result
> To see a string indicating one default value such as "Default is 
> 'http://localhost:7070/geode-mgmt/v1'"
> Actual result
> This string "optional --url: Indicates the base URL to the Manager's HTTP 
> service.  For example: 'http://<host>:<port>/gemfire/v1' Default is 
> 'http://localhost:7070/geode-mgmt/v1'; no default value"  Note the `Default 
> is` and the `no default value`
> steps to reproduce
> execute `gfsh`
> execute `start locator`
> execute `disconnect`
> type `connect --url`
> press tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to