[ 
https://issues.apache.org/jira/browse/GEODE-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102728#comment-17102728
 ] 

ASF subversion and git services commented on GEODE-8072:
--------------------------------------------------------

Commit daced1e4883a862ff39a938eb10a05a8ded8fb7c in geode's branch 
refs/heads/feature/GEODE-8072 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=daced1e ]

Revert "GEODE-8072: check the null and stop the on-going query function when … 
(#5053)"

This reverts commit 536910a62e6a5c0d6f46d2f42f467aa41ed40dc0.

Need to consider a better exception handling


> When cache is closing, the lucene query might still on-going, some NPE could 
> happen
> -----------------------------------------------------------------------------------
>
>                 Key: GEODE-8072
>                 URL: https://issues.apache.org/jira/browse/GEODE-8072
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Xiaojian Zhou
>            Assignee: Xiaojian Zhou
>            Priority: Major
>             Fix For: 1.14.0
>
>
> when the cache is closing, what detected recently is:
> RROR util.TestException: Got unexpected exception 
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.execute.InternalFunctionExecutionServiceImpl.onRegion(InternalFunctionExecutionServiceImpl.java:120)
>   at 
> org.apache.geode.cache.execute.FunctionService.onRegion(FunctionService.java:76)
>   at 
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.onRegion(PageableLuceneQueryResultsImpl.java:116)
>   at 
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.getValues(PageableLuceneQueryResultsImpl.java:110)
>   at 
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.getHitEntries(PageableLuceneQueryResultsImpl.java:91)
>   at 
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.advancePage(PageableLuceneQueryResultsImpl.java:139)
>   at 
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.hasNext(PageableLuceneQueryResultsImpl.java:148)
> It's not caused by any recently code changes, it's just a deep buried race 
> condition triggered. 
> I propose a simple fix to just check the null and throw an exception which 
> could be handled. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to