[
https://issues.apache.org/jira/browse/GEODE-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108466#comment-17108466
]
ASF GitHub Bot commented on GEODE-8122:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5122:
URL: https://github.com/apache/geode/pull/5122#discussion_r425933953
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
##########
@@ -1916,11 +1916,10 @@
/**
* The static String definition of the <i>"redis-port"</i> property <a
name="redis-port"/a>
* </p>
- * <U>Description</U>: Specifies the port used by {@code GeodeRedisServer}
which enables redis
- * clients to connect and store data in GemFire distributed system. see
{@code GeodeRedisServer}
- * for other configuration options. A value of "-1" will select a random
port.
+ * <U>Description</U>: Specifies the port used by Redis API for Geode which
enables redis
+ * clients to connect and store data in GemFire distributed system.
Review comment:
These selections are consistent with network services though. Zero
typically mean automatically pick an ephemeral port. Given that ports should
not be negative, can we use another property or API to enable service, or the
use of `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update GeodeRedisServer java doc and Redis API for Geode documentation
> ----------------------------------------------------------------------
>
> Key: GEODE-8122
> URL: https://issues.apache.org/jira/browse/GEODE-8122
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Sarah Abbey
> Priority: Major
>
> - Java doc for GeodeRedisServer updated for current GA release plans
> - Java doc for ConfigurationProperties updated so it doesn't reference
> internal GeodeRedisServer
> - Geode docs for Redis API for Geode updated
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
