[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108668#comment-17108668
]
ASF GitHub Bot commented on GEODE-8112:
---------------------------------------
DonalEvans commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426051856
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##########
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
- DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
I talked to Jens about it briefly and the `--file` argument is
definitely used, it just gets picked up by the interceptor on the gfsh command,
not used in the actual command itself. If you try to include the `--step-name`
option, then gfsh throws an error: `Option 'step-name' is not available for
this command.` The "step-name" string only appears in this one place too, with
no other occurrences in the codebase or the docs, so I can't think of a reason
to not remove it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
> --------------------------------------------
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
> Reporter: Eric Shu
> Assignee: Eric Shu
> Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
