[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110596#comment-17110596
]
ASF GitHub Bot commented on GEODE-7971:
---------------------------------------
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r426877956
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
##########
@@ -153,6 +155,13 @@
.getInteger(GeodeGlossary.GEMFIRE_PREFIX +
"gateway-connection-retry-interval", 1000)
.intValue();
+ /**
+ * Number of times to retry to get events for a transaction from the gateway
sender queue
+ */
+ int GET_TRANSACTION_EVENTS_FROM_QUEUE_RETRIES =
+ Integer.getInteger(GeodeGlossary.GEMFIRE_PREFIX +
"get-transaction-events-from-queue-retries",
Review comment:
I
> Apache Geode is an open-source repo, so nothing is truly hidden from
users. However, there are many examples of properties that intentionally go
un-mentioned in the User Guide. Such a property should be briefly commented in
code, indicating the use for which it is intended and what its limitations are,
so curious browsing developers won't get themselves into trouble.
I have added a longer description in the comments for the property in my
last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
> ----------------------------------------------------------------------------
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
