[
https://issues.apache.org/jira/browse/GEODE-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113350#comment-17113350
]
ASF GitHub Bot commented on GEODE-8137:
---------------------------------------
yozaner1324 commented on a change in pull request #5136:
URL: https://github.com/apache/geode/pull/5136#discussion_r428772297
##########
File path:
geode-modules/src/main/java/org/apache/geode/services/module/impl/JBossModuleService.java
##########
@@ -92,18 +98,20 @@ public boolean loadModule(ModuleDescriptor
moduleDescriptor) {
builder.addResourceRoot(ResourceLoaderSpec.createResourceLoaderSpec(resourceLoader));
}
} catch (IOException e) {
- logger.error(e);
+ logger.error(e.getMessage());
return false;
}
+
builder.addDependency(DependencySpec.createSystemDependencySpec(PathUtils.getPathSet(null)));
+
ModuleSpec moduleSpec = builder.create();
moduleLoader.addModuleSpec(moduleSpec);
try {
modules.put(moduleDescriptor.getVersionedName(),
moduleLoader.loadModule(moduleSpec.getName()));
} catch (ModuleLoadException e) {
- logger.error(e);
+ logger.error(e.getMessage());
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement loadService on JBossModuleService
> -------------------------------------------
>
> Key: GEODE-8137
> URL: https://issues.apache.org/jira/browse/GEODE-8137
> Project: Geode
> Issue Type: Sub-task
> Reporter: Patrick Johnsn
> Assignee: Patrick Johnsn
> Priority: Major
>
> Implement loadService to load implementations of a given interface from JBoss
> Modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
