[
https://issues.apache.org/jira/browse/GEODE-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113651#comment-17113651
]
ASF GitHub Bot commented on GEODE-8171:
---------------------------------------
agingade commented on a change in pull request #5147:
URL: https://github.com/apache/geode/pull/5147#discussion_r428981578
##########
File path: geode-core/src/main/java/org/apache/geode/cache/Region.java
##########
@@ -1359,10 +1359,30 @@ Object selectValue(String queryPredicate) throws
FunctionDomainException, TypeMi
* in the specified map. This operation will be distributed to other caches
if the scope is not
* <code>Scope.LOCAL</code>.
*
- * @param map the key/value pairs to put in this region.
- * @since GemFire 5.0
+ * If any exception is thrown due to this call, it can imply that there may
have been a partial
+ * update performed on the region. Use putAll from within a transaction to
get atomicity with all
+ * the
Review comment:
"the entries" are they in two different lines or it is my browser. If
they are two lines, it will be nice to have in the same line.
##########
File path:
geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/PutAllClientServerDistributedTest.java
##########
@@ -1827,6 +1829,135 @@ public void testPartialKeyInLocalRegion() {
});
}
+ /**
+ * Verify all the possible exceptions a putAll/put/removeAll/destroy could
return
+ */
+ @Test
+ public void testPutAllReturnsExceptions() {
Review comment:
May be changing it to "throwsExpectedExceptions"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> javadoc for putAll need to have accurate exception
> ---------------------------------------------------
>
> Key: GEODE-8171
> URL: https://issues.apache.org/jira/browse/GEODE-8171
> Project: Geode
> Issue Type: Improvement
> Reporter: Xiaojian Zhou
> Assignee: Xiaojian Zhou
> Priority: Major
> Labels: GeodeOperationAPI
>
> Both the javadocs and the user guide need a more accurate description of the
> exceptions that can be thrown when an app calls putAll().
> Correct the javadocs to list all exceptions that may be thrown.
> Add a code fragment example to the user guide (and to the javadocs, if
> appropriate) that shows a best practice for an app to call putAll() and
> handle exceptions.
> Describe what might cause the exceptions and let users know how to adjust
> cluster configuration mitigate the exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
