[
https://issues.apache.org/jira/browse/GEODE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114051#comment-17114051
]
ASF GitHub Bot commented on GEODE-8138:
---------------------------------------
sabbeyPivotal commented on a change in pull request #5142:
URL: https://github.com/apache/geode/pull/5142#discussion_r429255221
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
##########
@@ -1943,6 +1931,36 @@
* <U>Default</U>: ""
*/
String REDIS_PASSWORD = "redis-password";
+ /**
+ * The static String definition of the <i>"redis-port"</i> property <a
name="redis-port"/a>
+ * </p>
+ * <U>Description</U>: Specifies the port used by Redis API for Geode which
enables Redis
+ * clients to connect and store data in GemFire distributed system. A value
of 0 will select a
+ * random port.
+ * </p>
+ * <U>Default</U>: "6379"
+ * </p>
+ * <U>Allowed values</U>: 0..65535
+ */
+ String REDIS_PORT = "redis-port";
+ /**
+ * The static String definition of the <i>"redis-service-enabled"</i>
property <a
+ * name="redis-service-enabled"/a>
+ * </p>
+ * <U>Description</U>: When the default value of false, the Redis API for
Geode is not available.
+ * Set to true to enable the Redis API for Geode.</td>
+ * </p>
+ * <U>Default</U>: false
+ * <td>redis-service-enabled</td>
+ * <td>When the default value of false, the Redis API for
<%=vars.product_name%> is not available.
+ * Set
+ * to true to enable the Redis API for <%=vars.product_name%>.</td>
+ * <td>S</td>
+ * <td>false</td>
+ * </tr>
+ * </p>
+ */
+ String REDIS_SERVICE_ENABLED = "redis-service-enabled";
Review comment:
Yeah, we can make it `redis-enabled`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve semantics of the redis-port option
> ------------------------------------------
>
> Key: GEODE-8138
> URL: https://issues.apache.org/jira/browse/GEODE-8138
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
>
> Currently when {{redis-port=0}} the Redis service is not enabled. Recently we
> added the ability to pick an ephemeral port by setting {{redis-port=-1}}.
> However the typical norm is that a port of {{0}} should indicate the use of
> an ephemeral port.
> If we allow this then we need a different way of enabling/disabling the
> service.
> One possibility is that the service is disabled when {{redis-port=-1}}. (or <
> 0). However anyone already setting the property to {{0}} would then suddenly
> activate the service.
> Another possibility is to add a new Geode property to explicitly
> enable/disable the service. (Off by default). That way users, switching to
> this version, would still experience the same behavior regardless of their
> {{redis-port}} setting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
