[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118790#comment-17118790
]
ASF GitHub Bot commented on GEODE-8181:
---------------------------------------
pdxcodemonkey commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431908122
##########
File path: cppcache/integration-test/testSystemProperties.cpp
##########
@@ -80,7 +80,7 @@ BEGIN_TEST(NEW_CONFIG)
std::chrono::seconds(700),
"expected 700");
- ASSERT(systemProperties->statisticsEnabled() == false, "expected false");
+ ASSERT(systemProperties->statisticsEnabled() == true, "expected false");
Review comment:
Same here
##########
File path: cppcache/integration-test/testSystemProperties.cpp
##########
@@ -51,7 +51,7 @@ BEGIN_TEST(DEFAULT)
ASSERT(
systemProperties->statisticsSampleInterval() ==
std::chrono::seconds(1),
"expected 1");
- ASSERT(systemProperties->statisticsEnabled() == true, "expected true");
+ ASSERT(systemProperties->statisticsEnabled() == false, "expected true");
Review comment:
The string description should now be "expected false," no?
##########
File path: cppcache/integration-test/resources/system.properties
##########
@@ -14,7 +14,7 @@
# limitations under the License.
# All the configurable parameters.
statistic-sample-rate=700s
-statistic-sampling-enabled=false
+statistic-sampling-enabled=true
Review comment:
I don't understand this change. Doesn't this change the value to true
for _all_ integration tests now? I thought only the expiration tests required
this, i.e. the two places where you're now explicitly enabling them in test
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> ------------------------------------------------------
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
